Skip to content

chore(predict): remove dummy transactions from withdraw/deposit #21649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2025
Merged

chore(predict): remove dummy transactions from withdraw/deposit #21649

merged 3 commits into from
Oct 27, 2025
+258 −37

Conversation

@caieu
Copy link
Contributor

@caieu caieu commented Oct 24, 2025 •
edited by cursor bot
Loading

Description

  • Removes dummy transactions from Withdraw and Deposit
  • Add executionGuard to withdraw

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes dummy transactions from claim/withdraw batches and wraps withdraw in a guarded action; expands PredictBalance UI behaviors and tests.

  • Backend (PredictController):
    • Transactions: Remove dummy transactions from addTransactionBatch calls in claimWithConfirmation and prepareWithdraw; pass only provider-prepared transactions/transaction.
    • Withdraw: Maintain state updates; tests adjusted to expect single withdraw transaction in batch.
  • Frontend (PredictBalance):
    • Withdraw Action Guard: handleWithdraw now uses executeGuardedAction(..., { checkBalance: true }).
    • Deposit Status UI: Renders "adding your funds" banner while PredictDepositStatus.PENDING.
  • Tests:
    • Update mocks to lowercase PredictDepositStatus values; add usePredictWithdraw mock.
    • Add/expand tests for guarded actions, pending deposit UI, onLayout callback, balance formatting edge cases, and button states.

Written by Cursor Bugbot for commit 77874a7. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-predict Predict team label Oct 24, 2025
@caieu caieu marked this pull request as ready for review October 27, 2025 13:58
matallui
matallui previously approved these changes Oct 27, 2025
View reviewed changes
@matallui matallui enabled auto-merge October 27, 2025 15:05
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@matallui matallui added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Oct 27, 2025
@matallui matallui added this pull request to the merge queue Oct 27, 2025
auto-merge was automatically disabled October 27, 2025 17:17

Pull Request is not mergeable

Merged via the queue into main with commit 72b79ca Oct 27, 2025
150 of 153 checks passed
@matallui matallui deleted the chore/withdraw-fixes branch October 27, 2025 17:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Oct 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matallui matallui matallui approved these changes

Assignees

No one assigned

Labels

release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-M skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-predict Predict team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caieu @matallui @metamaskbot